Fabio Massimo Ercoli
Fabio Massimo Ercoli
Thank you @tristantarrant
@marko-bekhta I just rebased the PR on top of the current main branch. Now I'm resuming to doing the changes...
I just added two last commits to address the last @yrodiere's suggestions. Once we're fine with them, I'll reorganize the commits.
Thanks @yrodiere I applied all the great suggestions here. My only doubt is a about the last change that I added in a different commit: https://github.com/hibernate/hibernate-search/pull/4144/commits/a807e2c39d8b1bb3dad7e708138f0a37631be94d. In my opinion returning...
> > we could expose two avg operations, one returning always a double and one returning the field type to support the exotic cases such as avg of a date....
> > > > we could expose two avg operations, one returning always a double and one returning the field type to support the exotic cases such as avg of...
> unconverted type (ValueConvert.NO, would be double I guess). OK so I can revert the last commit?
> > If I try to ask for a double a get this error in my test: > > With `ValueConvert.NO`? > > > > unconverted type (ValueConvert.NO, would be...
Hi @marko-bekhta, the commit [HSEARCH-5133 Test all types with metric aggregations](https://github.com/hibernate/hibernate-search/pull/4144/commits/9abb07f596266759166bf40ae67660369c775228) is in progress and I still need to address the other unresolved conversation. I will continue to work on...
With this last push I think I have only one comment to address, the one about introducing `abstract List