quran-api icon indicating copy to clipboard operation
quran-api copied to clipboard

Published 20 hours ago • verified publisher icon fawazahmed0

Danish translation is actually Dutch

Open 0x1eef opened this issue 2 years ago • 4 comments

The dan-vandetaal translation is not Danish but Dutch - as far as I can tell. Should it be stored as nld-vandetaal instead ?

0x1eef avatar Jul 30 '23 20:07 0x1eef

Thanks, will take a look.

Should it be stored as nld-vandetaal instead ?

Yes, I will have to create nld-vandetaal while still keeping the dan-vandetaal edition

fawazahmed0 avatar Jul 30 '23 23:07 fawazahmed0

Thanks for the quick reply.

Yes, I will have to create nld-vandetaal while still keeping the dan-vandetaal edition

I understand that makes sense from the perspective of an API version, but it might be misleading to those who assume the language is Danish. Maybe it is a good reason to have v1.1 of the API where the issue can be addressed by removing dan-vandetaal.

0x1eef avatar Jul 31 '23 13:07 0x1eef

The translation is available in nld-unknown. I have updated the author name without changing the link

fawazahmed0 avatar Jul 31 '23 19:07 fawazahmed0

Alright :+1: Welcome to close if that resolves it.

0x1eef avatar Jul 31 '23 19:07 0x1eef