pogom icon indicating copy to clipboard operation
pogom copied to clipboard

Added GMaps search box to top-right corner

Open ensingm2 opened this issue 8 years ago • 7 comments

Not sure if this one should be added or not. It's super useful, but requires 'Google Places API Web Service' to be enabled in the user's Google API (Not having this enabled doesn't BREAK anything else, but it doesn't remove the nonfunctional search box either, and the console will yell at you if you try to search).

You may need to edit the README and tell users to add the extra Lib for this one.

ensingm2 avatar Aug 09 '16 09:08 ensingm2

@ensingm2 How does this show up on Mobile?

ghost avatar Aug 09 '16 21:08 ghost

@Lionir Looks fine to me (tested in chrome-beta, firefox on android), I'm running on a 1440p phone through so someone may want to test it on a more standard res. Give me a sec and I'll put up some screens.

EDIT: Screens. Autocomplete overlaps menu button while typing, but I don't think that's an issue. searchbar1 searchbar2

ensingm2 avatar Aug 09 '16 22:08 ensingm2

@ensingm2 I think it'd be better if you could make it part of the sidebar, don't you think? (Maybe at the top of the sidebar) Now that I think about it, what if it could also act to find Pokemons currently on the map? (I know I might be asking much but I think that'd be an awesome feature)

ghost avatar Aug 10 '16 07:08 ghost

How did you add this?

MasterGameZ avatar Aug 11 '16 00:08 MasterGameZ

@MasterGameZ: I pretty much just used the relevant code from the Google example at: https://developers.google.com/maps/documentation/javascript/examples/places-searchbox

ensingm2 avatar Aug 11 '16 00:08 ensingm2

Can you send me the replaced files please?

MasterGameZ avatar Aug 11 '16 01:08 MasterGameZ

You can find the files by clicking on the commits at the top of this PR and then pressing 'view' (though they aren't up to date with current master). Keep in mind you need to add the Google Places API Web Service to your API key as well.

ensingm2 avatar Aug 11 '16 01:08 ensingm2