faust
faust copied to clipboard
fixed StreamT annotations, TPorTopicSet can also be optional
Note: Before submitting this pull request, please review our contributing guidelines.
Description
- Fixed / added type annotations mostly for
StreamTclass. - Fixed generic argument for
EventTclass. - Make sure that App.commit accepts
Noneas a documentation saying (https://faust-streaming.github.io/faust/reference/faust.app.html#faust.app.App.commit) - Removed
__iter__/__aiter__methods onStreamT. And it makes sense, because it is extendingAsyncIterable, which already implements__aiter__.__iter__was just redundant here and broke typing.
please review @wbarnha
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.09%. Comparing base (
ff75c0b) to head (a44deff).
Additional details and impacted files
@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 102 102
Lines 11100 11100
Branches 1196 1196
=======================================
Hits 10444 10444
Misses 557 557
Partials 99 99
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Thanks! Seems that pypy doesn't like my changes, btw. Is it because of me or they were failing before?