faust icon indicating copy to clipboard operation
faust copied to clipboard

Replace aredis with redis-py

Open wbarnha opened this issue 1 year ago • 3 comments

We need to get aredis out of Faust since it uses distutils, a library removed in Python 3.12.

wbarnha avatar Jul 16 '24 13:07 wbarnha

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.09%. Comparing base (da2d10e) to head (36cd35e). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
faust/web/cache/backends/redis.py 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   94.13%   94.09%   -0.05%     
==========================================
  Files         102      102              
  Lines       11093    11100       +7     
  Branches     1327     1328       +1     
==========================================
+ Hits        10442    10444       +2     
- Misses        554      557       +3     
- Partials       97       99       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Jul 16 '24 14:07 codecov[bot]

Faust doesn't work with ardis, because aredis support by python until 3.8. Miracle, python 3.9 is working with aredis, Faust with 3.11 doesn't work. We move with aredis to redis-py 🙏

Luferov avatar Jul 23 '24 14:07 Luferov

I'm waiting to merge this until I've tested this against an actual Redis instance.

wbarnha avatar Jul 24 '24 20:07 wbarnha

We're going to have to get this merged if we want to support newer versions of Python.

wbarnha avatar Nov 19 '24 02:11 wbarnha