faust icon indicating copy to clipboard operation
faust copied to clipboard

fix running `make develop` and restore `pre-commit` tool

Open taybin opened this issue 4 years ago • 3 comments

Description

This is a work in progress for #132, fixing make develop. As I said in that issue,

I fixed this, but then I saw that make develop still breaks because it runs pip install -r requirements/dist.txt, and that references a non-existent flakes.txt file. Should the flake8 linters be moved to that? Or should the line be deleted from dist.txt? Or is the Makefile not really used anymore? In that case, maybe it should be trimmed down to what is used or even deleted entirely.

taybin avatar May 03 '21 21:05 taybin

Codecov Report

Merging #145 (2d25630) into master (ce53c40) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files         100      100           
  Lines       10915    10915           
  Branches     1531     1531           
=======================================
  Hits        10303    10303           
  Misses        534      534           
  Partials       78       78           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar May 03 '21 21:05 codecov-commenter

This fixes another couple inclusions of files that don't exist. The Makefile still tries to run pre-commit, which isn't listed in any of the requirements files either.

I like pre-commit myself, but I have a coworker who doesn't, so I'm hesitant to just add it in as another requirement.

taybin avatar May 03 '21 21:05 taybin

After seeing that pre-commit was used in the upstream of faust, I added it back in with support for running flake8. It won't be installed unless you run make develop, so that seems okay to me.

I'd like to have it run black and isort as well, but that'll go in a different PR.

taybin avatar May 03 '21 22:05 taybin

I don't personally use pre-commit or the Makefile (yet) but I support these changes particularly because it cleans up the requirements files. LGTM.

wbarnha avatar Aug 31 '22 13:08 wbarnha