ctf-gameserver
ctf-gameserver copied to clipboard
Rust Checkerlib
- [x] trivialchecker wants to go to toplevel examples
- [x] could integrate "proper" logging
- [ ] Handle Standard Errors
- [ ] Set Timeouts
Nice! I assume this is still work in progress for now?
Some remarks from my side:
- [ ] Please resolve the duplication between "/rust/examples" and "/examples/checker/checker_rust" (in favor of the latter).
- [ ] Ideally, extend the example checker to check our example service (as for Python and Go).
- [ ] "Cargo.toml" for the example checker should reference our upstream repo and maybe contain author information.
- [ ] My Rust is probably not good enough, but can you explain why in "context.rs", you perform
matches which do the same thing in all cases? - [ ] Local flag generation appears pretty static for now. Having it working more dynamically does seem desirable when checking for the presence of flags, doesn't it?
- [ ] Please apply some formatting using rustfmt or whatever you deem suitable, especially regarding whitespace (e.g. superfluous newlines in "flag.rs").
- [ ] Don't have particular insights on Rust package naming, but not sure if "checkerlib" is the best choice for a global name.