udmi icon indicating copy to clipboard operation
udmi copied to clipboard

Validator does not allow null present_value

Open DollyGodet opened this issue 2 years ago • 2 comments

Here is the pointset_event I am trying to validate with the validator :

  
{
  "timestamp": "2022-06-30T13:48:13.375Z",
  "version": "1.3.13",
  "points": {
    "schedule1": {
      "present_value": null
    },
    "binary_value1": {
      "present_value": "Active"
    },
    "analog_value1": {
      "present_value": 6.0
    },
    "multi_state_value1": {
      "present_value": 1
    }
  }
}
  

It looks like the validator does not accept null present_value. Here is the content of the event_pointset.out file :

  
While converting to json node: 1 schema violations found
  1 schema violations found
    object has missing required properties (["present_value"])
  

I think the validator should accept a null present_value, because some BACnet object can have a null present_value (and it is valid). For exemple, a schedule object can have a null present_value. The present_value field is required, but the ObjectMapper of the validator considers a null value as a missing property.

DollyGodet avatar Jun 30 '22 18:06 DollyGodet

I agree with you, I think null should be acceptable value. Tagging @grafnu

noursaidi avatar Jul 12 '22 12:07 noursaidi

Works for me!

On Tue, Jul 12, 2022 at 5:55 AM Noureddine @.***> wrote:

I agree with you, I think null should be acceptable value. Tagging @grafnu https://github.com/grafnu

— Reply to this email directly, view it on GitHub https://github.com/faucetsdn/udmi/issues/383#issuecomment-1181726859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPD5Z3U4WOV2F3PWLBMLVTVTMXANCNFSM52KHLOGQ . You are receiving this because you were mentioned.Message ID: @.***>

grafnu avatar Jul 12 '22 13:07 grafnu