daq icon indicating copy to clipboard operation
daq copied to clipboard

Pics Failing Unsupported Types Instead of Skipping

Open jhughesbiot opened this issue 3 years ago • 0 comments

If the pics file has the value false in the supported column, the pics statement is generating failure results instead of skipping. It appears there is no catch all for when a property is not supported so the default behavior is to use the false value in the testPassed variable.

This is where I believe the change needs to occur. https://github.com/faucetsdn/daq/blob/73d7504f7264f3b3bfafb378bdf04fe87e882781/subset/bacnet/bacnetTests/src/main/java/helper/PicsValidator.java#L21

Likely not caught due to the faux devices pics.csv being used in testing has no objects defined as false in the support column.

https://github.com/faucetsdn/daq/blob/73d7504f7264f3b3bfafb378bdf04fe87e882781/docker/include/bacnet/bacnetFaux/src/main/resources/pics.csv

jhughesbiot avatar Jun 22 '21 17:06 jhughesbiot