daq
daq copied to clipboard
faucetsdn
Running cmd/run java 11 support
With java 11 installed, you cannot run cmd/run as it is not recognized.
$cmd/run -s Activating venv Loading config from local/system.conf Starting Tue Jun 18 22:39:58 UTC 2019, run_mode is local. Clearing previous state... Running as root... Activating venv Loading config from local/system.conf Release version 1.0.0 ovsdb-server is running with pid 8208 ovs-vswitchd is running with pid 8276 Creating mudacl templates...
FAILURE: Build failed with an exception.
- What went wrong: Could not determine java version from '11.0.3'.
I fixed this locally by increasing the gradle wrapper for the mudacl files to 5.1.1 and a few associated build files since shadow command creates a slightly different named jar. I can create a PR for this update unless increasing the gradlew wrapper is an issue for a different part of the build?
The only strict requirement is that the Travis CI builds complete ok... There might be some hidden problems, but those parts of the code aren't "critical". So, basically wouldn't know it's an issue until you try. Also note that if you do the PR against my personal repo (grafnu/daq), then it will run against my Travis CI setup. For administrative reasons the faucetsdn/daq repo isn't setup to do this. I really don't know what to expect... so just gotta try it!
On Wed, Jun 19, 2019 at 7:53 AM jhughesbiot [email protected] wrote:
I fixed this locally by increasing the gradle wrapper for the mudacl files to 5.1.1 and a few associated build files since shadow command creates a slightly different named jar. I can create a PR for this update unless increasing the gradlew wrapper is an issue for a different part of the build?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/issues/148?email_source=notifications&email_token=AAIEPD7NUC3ZAXT3Z2AH3WLP3JB6JA5CNFSM4HZEPOL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCEBCQ#issuecomment-503595146, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEPD5DDMUPTRB5TWFW6VLP3JB6JANCNFSM4HZEPOLQ .
It can get slow when there's a lot of stuff going on... it was a fine setup when there were only a few people doing things infrequently, but it's not scaling will. Will have to sort out the dev pipeline soonish...
On Wed, Jun 19, 2019 at 10:06 AM jhughesbiot [email protected] wrote:
Submitted a PR about an hour ago but the CI is still pending.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/issues/148?email_source=notifications&email_token=AAIEPD3HPEMNYOGK4ARUIK3P3JRSRA5CNFSM4HZEPOL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCQZ7Y#issuecomment-503647487, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEPD2RWTTOYAX5DA7FMMTP3JRSRANCNFSM4HZEPOLQ .
I don't see the PR? Where is it (add link here is easiest)?
On Wed, Jun 19, 2019 at 11:03 AM Trevor Pering [email protected] wrote:
It can get slow when there's a lot of stuff going on... it was a fine setup when there were only a few people doing things infrequently, but it's not scaling will. Will have to sort out the dev pipeline soonish...
On Wed, Jun 19, 2019 at 10:06 AM jhughesbiot [email protected] wrote:
Submitted a PR about an hour ago but the CI is still pending.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/faucetsdn/daq/issues/148?email_source=notifications&email_token=AAIEPD3HPEMNYOGK4ARUIK3P3JRSRA5CNFSM4HZEPOL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCQZ7Y#issuecomment-503647487, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIEPD2RWTTOYAX5DA7FMMTP3JRSRANCNFSM4HZEPOLQ .