Carl-Erik Kopseng
Carl-Erik Kopseng
Similar PR in #5644
The pattern using [`sinon.replace.usingAccessor(obj,prop,val)`](https://sinonjs.org/releases/v19/sandbox/#:~:text=sandbox.replace.usingAccessor(object%2C%20property%2C%20value)%3B) is quite a bit wordier than @forty's suggestion. Both approaches are explicit, at least. I don't think this custom approach should be part of Sinon. After...
@dependabot rebase
Excellent report! Thanks for taking the time. This seems doable, but I can't do this in the immediate future. Unless you can see a quick fix (which it seemed lik...
I started working on this last night, moving our current hashmap approach into one using lists instead. The idea being that I could then pop a timer of the list...
oooh, good catch! We have not caught this, nor do we have a test for it. we could still do an async `await import(...)`, though, to fix this, I guess,...
No ... but I am not sure how that works. I usually try to map these newer constructs over to how this would look in ES5, but I cannot see...
Gah, this was hard, Ben. I have tried out [top-level await ](https://github.com/sinonjs/fake-timers/compare/main...fatso83:lolex:489-fix-skypack?expand=1), but getting that and CJS to work together was non-trivial, so it ended up just being a ESM...
Just to add some details on why this is not moving: - when using `require` the modules need to exist for Skypack to work - one can use `import()` in...
It's not the only way, btw. We can re-introduce a bundler (which was removed in #345), which could simply create a bundle where those modules were not available, which is...