redtimer icon indicating copy to clipboard operation
redtimer copied to clipboard

Add comments

Open fathomssen opened this issue 8 years ago • 10 comments

Add a text field to write comments which will be appended to the issue.

fathomssen avatar May 27 '16 16:05 fathomssen

It's really quite important thing when a developer or a tester ad some comment when they finish do the job.

Warlib1975 avatar Jul 17 '17 12:07 Warlib1975

I have to agree.. time entries with no comments make this nearly unusable for us.. this is a great tool and would like to use it.

TyRoden avatar Jul 21 '17 17:07 TyRoden

Where would you suggest the comment field should be? Right beneath the timer, above the activity selection?

fathomssen avatar Jul 21 '17 17:07 fathomssen

I would say below the timer.. thats where I naturally would look for it.

On Fri, Jul 21, 2017 at 1:21 PM, Frederick Thomssen < [email protected]> wrote:

Where would you suggest the comment field should be? Right beneath the timer, above the activity selection?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fathomssen/redtimer/issues/24#issuecomment-317061005, or mute the thread https://github.com/notifications/unsubscribe-auth/AHglyjPPcpiLNBSsWPSYZmWb0I7qSoptks5sQN4ggaJpZM4IoqHm .

TyRoden avatar Jul 22 '17 02:07 TyRoden

Sounds reasonable. What about the case when you (like I) use keyboard shortcuts most of the time?

Should the last value of the comment field be used (does that even make sense?) or should the comment field be left empty?

Or should you get a pop-up window asking you for a comment? This might not work properly in environments with multiple desktops (you simply would not notice the new window).

fathomssen avatar Jul 22 '17 13:07 fathomssen

I think comment field should be empty. The process are:

  1. Developer turn on the timer.
  2. When he has finished the job, he writes comments and stop timer.
  3. It would be good if it was possibility to stop timer, then write comment and save it. Just for any case, if developer forgot the sequence.

Comment window may be instead of issue description. E.g. when timer is started description tab switched to comment tab.

I believe that there is no any additional pop-up window, since comment - it's not obliging field.

Warlib1975 avatar Jul 24 '17 06:07 Warlib1975

There is no easy way to amend a time booking after it has been sent to Redmine. So it will be required to enter the comment before stopping the timer.

I would suggest the following implementation:

  1. There will be a new configuration option in the settings dialog that specifies whether a comment is mandatory.
  2. If the comment is NOT mandatory, it MAY be typed into the comment fields and will be saved. If it is left empty, that's OK as well.
  3. If the comment IS mandatory and it has not been specified in the comment field, a message will pop up upon stopping the timer. The timer will continue to count until a comment has been specified and the timer has been stopped again.

What do you think about this approach?

Best regards Frederick Thomssen

fathomssen avatar Jul 24 '17 18:07 fathomssen

I believe it's a good decision. :-)

Warlib1975 avatar Jul 24 '17 18:07 Warlib1975

I like the switch for comment mandatory or not. If mandatory, merely popup the app from the tray and show the comment field with the cursor sitting ready (that way if using shortcuts it works fine)

On Mon, Jul 24, 2017 at 2:10 PM, Frederick Thomssen < [email protected]> wrote:

There is no easy way to amend a time booking after it has been sent to Redmine. So it will be required to enter the comment before stopping the timer.

I would suggest the following implementation:

  1. There will be a new configuration option in the settings dialog that specifies whether a comment is mandatory.
  2. If the comment is NOT mandatory, it MAY be typed into the comment fields and will be saved. If it is left empty, that's OK as well.
  3. If the comment IS mandatory and it has not been specified in the comment field, a message will pop up upon stopping the timer. The timer will continue to count until a comment has been specified and the timer has been stopped again.

What do you think about this approach?

Best regards Frederick Thomssen

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fathomssen/redtimer/issues/24#issuecomment-317507824, or mute the thread https://github.com/notifications/unsubscribe-auth/AHglylBoTwAff7s_et-XvBq77xvu3LtGks5sRN4ngaJpZM4IoqHm .

TyRoden avatar Jul 24 '17 18:07 TyRoden

Adding a comment is very important for me too. Would be great if that would be implemented.

kristian-b avatar Oct 19 '17 07:10 kristian-b