fat_free_crm icon indicating copy to clipboard operation
fat_free_crm copied to clipboard

Internationalize phone numbers

Open johnnyshields opened this issue 7 years ago • 3 comments

  • All phone inputs should use: https://github.com/jackocnr/intl-tel-input
  • Phone numbers should be stored in and validated as E.164 format, e.g. "+12061234567" for a US phone number.
  • Existing phone data which doesn't start with a plus should be displayed as is, and the user should see a message "please migrate your phone data to E.164 format"

johnnyshields avatar Jan 18 '18 13:01 johnnyshields

I like the control, but that's going to be a lot of data migration for a lot of people, some who would only do business within their own country. When this lands, we'll want a lot of data migration helpers/rake tasks/etc to make it as painless as possible

CloCkWeRX avatar Jan 19 '18 00:01 CloCkWeRX

Agree. Could we make it an optional extra that can be turned on? I can see it being very useful for some but not all.

On Fri, Jan 19, 2018, 08:02 CloCkWeRX [email protected] wrote:

I like the control, but that's going to be a lot of data migration for a lot of people, some who would only do business within their own country. When this lands, we'll want a lot of data migration helpers/rake tasks/etc to make it as painless as possible

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fatfreecrm/fat_free_crm/issues/701#issuecomment-358823000, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJGzn76jzXNlu6x0svdb-CsUji9jB_cks5tL9uMgaJpZM4Ri5PY .

steveyken avatar Jan 19 '18 03:01 steveyken

@CloCkWeRX @steveyken it's a best practice to store all phone numbers in the DB as E.164 format (we can add a seperate "phone_extension" field as extensions aren't included in E.164)

I'm fine add a "international phone" option in the settings but I think it should be set to true for newly created apps when you run "ffcrm:setup"

johnnyshields avatar Jan 20 '18 08:01 johnnyshields