points icon indicating copy to clipboard operation
points copied to clipboard

GitHub information with no user name shows a blank name in the views

Open arielj opened this issue 2 years ago • 1 comments

Branch/Commit:

Main branch.

Expected behavior:

When a GitHub user information is missing the name, we should fallback to other information, like the github handle.

Actual behavior:

When the Github user name is empty, the name is blank: image

Steps to reproduce:

How do I achieve this behavior? Use the following format to provide a step-by-step guide:

  1. Log in into Points with a Github user that has no name
  2. Add some estimates
  3. Go to the report page

Also, add comments to a story, in the comments we also use the user's name.

Aditional information

We'll probably need to update the ombu_labs-auth game for this https://github.com/fastruby/ombu_labs-auth/blob/main/app/models/concerns/ombu_labs_authenticable.rb#L16

I will abide by the code of conduct

arielj avatar Nov 01 '23 18:11 arielj

This was also happening when adding comments in the stories

JuanVqz avatar Nov 01 '23 18:11 JuanVqz