go-fastly icon indicating copy to clipboard operation
go-fastly copied to clipboard

Allow to manage default cert for custom TLS configurations

Open jenskueper opened this issue 1 year ago • 4 comments

This PR allows to manage the default certificate for custom TLS configuration. This is relevant for PlatformTLS.

jenskueper avatar Oct 14 '24 11:10 jenskueper

After some internal discussion it's going to be slightly challenging to accept this PR. While the code for the API endpoint is fine, the tests are not, because they will fail unless they are run using a user account that has one of the (limited) products enabled which support this field.

I think we'll need to have a separate set of test fixtures and test cases, which are skipped unless an environment variable named TEST_TLS_DEFAULT_CERTFICATE is set.

CC @Integralist

kpfleming avatar Nov 01 '24 19:11 kpfleming

The tests are run initially against the live API and those responses are saved into fixture files.

If the fixtures don't need updating any time soon then maybe it's fine. But yes, upgrading will require someone with access to this feature.

Integralist avatar Nov 02 '24 07:11 Integralist

Hey, sorry for taking so long to get back to you. Should I modify the test case to only run conditionally or do you want to update the fixtures on your side?

jenskueper avatar Jan 13 '25 14:01 jenskueper

No problem; I'd prefer to see a new set of test cases/fixtures which are only run when a suitable environment variable is set to trigger them.

kpfleming avatar Jan 13 '25 15:01 kpfleming