go-fastly icon indicating copy to clipboard operation
go-fastly copied to clipboard

Published 20 hours ago • verified publisher icon fastly

backends: allow clearing at least some fields on update

Open dkegel-fastly opened this issue 3 years ago • 4 comments

Partial fix for https://github.com/fastly/go-fastly/issues/371 ?

dkegel-fastly avatar Oct 06 '22 19:10 dkegel-fastly

I'm concerned about this causing subtle breakage for our users.

dgryski avatar Oct 07 '22 00:10 dgryski

Me, too.

Do we need a 2nd endpoint for the new behavior, or some other way of overloading?

dkegel-fastly avatar Oct 07 '22 00:10 dkegel-fastly

I'm concerned about this causing subtle breakage for our users.

We can just do a major version update then, no?

This typo has been bugging me for a bit so I could fix that and maybe some other breaking changes as part of the next major release.

Integralist avatar Oct 07 '22 08:10 Integralist

If we have a bunch of breaking changes lined up, that's not a bad plan. We could write some tooling (semgrep/ruleguard) to detect/fix the common ones.

dgryski avatar Oct 07 '22 15:10 dgryski

One breaking change might be "generate this sdk with https://github.com/fastly/api-clients-generator/ "

dkegel-fastly avatar Oct 21 '22 13:10 dkegel-fastly

Closing in favour of https://github.com/fastly/go-fastly/pull/375

Integralist avatar Oct 24 '22 13:10 Integralist