go-fastly icon indicating copy to clipboard operation
go-fastly copied to clipboard

Typo in Datacenter.Coordinates - Longtitude

Open briemarie opened this issue 3 years ago • 2 comments

I'm happy to contribute to fixing this, but wanted to raise an issue to get a consensus on how trivial it actually is.

Would getting the typo fixed in the name cause the need for a major revision change? At least the mapstructure tag is spelled correctly, so its not a big deal, found it when I spelled it correctly and got an error though.

https://github.com/fastly/go-fastly/blob/main/fastly/datacenters.go#L6

Screen Shot 2021-05-10 at 5 54 04 PM

briemarie avatar May 11 '21 00:05 briemarie

Hi @briemarie I personally would consider this a breaking change because Coordinates is a publicly exported type and so there may well be users of go-fastly that have code written using the misspelling of Longtitude.

Integralist avatar May 11 '21 08:05 Integralist

This is fairly straight-forward to add a semgrep or ruleguard rule to make upgrading automatic.

OTOH, https://en.wikipedia.org/wiki/HTTP_referer

dgryski avatar Aug 16 '22 18:08 dgryski