compute-sdk-go icon indicating copy to clipboard operation
compute-sdk-go copied to clipboard

Investigate io.NopCloser flake

Open dgryski opened this issue 5 months ago • 2 comments

=== RUN   TestRequestUpstreamBody/io.NopCloser
        Header[transfer-encoding] = "", want "chunked"
        Header[content-length] = "65536", want ""
    --- FAIL: TestRequestUpstreamBody/io.NopCloser (0.03s)

dgryski avatar Sep 16 '25 17:09 dgryski

I am not sure why it is not sending chunked, although I am not complaining! But I chose io.NopCloser originally because it was expedient. Another way to do this would be to implement a bespoke io.Reader where the platform would not know how much data is being generated.

joeshaw avatar Sep 16 '25 19:09 joeshaw

What I'm not sure of is if this is flaky on the client or server side.

cee-dub avatar Sep 17 '25 04:09 cee-dub