docs icon indicating copy to clipboard operation
docs copied to clipboard

[WIP] operating system incompatibility

Open janpio opened this issue 7 years ago • 4 comments

This PR relates to and depends on https://github.com/fastlane/fastlane/pull/13703

TODO:

  • [x] Update documentation in fastlane codebase to reflect the changes here "Action 'scan' is not compatible with operating system 'Windows'. For information how to handle this check out: TODO"
  • [ ] Update the documentation in this branch to reflect the TODO changes made to this line https://github.com/fastlane/fastlane/pull/13703/files#diff-dddea7a7468572e88e5b764b4506d25f15bb446e711e69c7413bc9cb85cccaccR308
  • [x] Add FASTLANE_IGNORE_OS_INCOMPAT functionality to fastlane
  • [x] Add def self.is_incompatible?(operating_system) functionality to fastlane
  • [x] Add def self.is_incompatible?(operating_system) generation to fastlane new_action and fastlane new_plugin

janpio avatar Nov 23 '18 17:11 janpio

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 07 '21 01:03 google-cla[bot]

@googlebot I consent.

rogerluan avatar Mar 07 '21 02:03 rogerluan

@janpio I like the idea of this doc very much!

I took the liberty of pushing a general formatting commit to your branch, and merged latest changes to it as well. Hope you don't mind 😇

Looks like this PR is very close from completion, what did you have in mind for the TODO comment in the code here? https://github.com/fastlane/fastlane/pull/13703/files#diff-dddea7a7468572e88e5b764b4506d25f15bb446e711e69c7413bc9cb85cccaccR308

rogerluan avatar Mar 07 '21 02:03 rogerluan

The general idea was to have documentation how to work around this, and possibly also give people an idea how to contribute improvements and fixes that could help here.

janpio avatar Mar 09 '21 12:03 janpio