xcov icon indicating copy to clipboard operation
xcov copied to clipboard

Files ignored in .xcovignore, but appearing in coverage report

Open sauvage7 opened this issue 6 years ago • 7 comments

Hi @nakiostudio Like statet in the title, one of my team mates discovered something odd: files which were added into .xcovignore were also ignored during the coverage calculation (I can see this in the console which files were ignored), but they appear in the .html coverage report (and everywhere is 0%). Is this by intent?

sauvage7 avatar Jan 24 '18 11:01 sauvage7

Including ignored files in HTML report seems a bit confusing (slightly related to #93). @nakiostudio Is there any reason to include them in the reports?

thelvis4 avatar Jan 27 '18 10:01 thelvis4

Hi @sauvage7 and @thelvis4 👋

The idea was to exclude the ignored files coverage from the target overall coverage but don't exclude the files from the report and somehow mark them as ignored. A file might be worth ignoring to you but maybe not to other team member.

Given that the idea is not clear and it's source of confusion I'm going to open a PR excluding ignored files from coverage reports. Makes sense?

nakiostudio avatar Jan 27 '18 11:01 nakiostudio

@nakiostudio I'm facing the same issue, any plan to open the PR? Thanks.

wtyeh avatar Sep 11 '18 04:09 wtyeh

+1

dai-cb avatar Sep 25 '18 13:09 dai-cb

Any update on this?

dogo avatar Jun 04 '20 21:06 dogo

Hi, any news on this? :)

KacperCzapp avatar Jun 02 '21 06:06 KacperCzapp

Hello, any updates this is still happening????

BrandonWalker88 avatar Aug 24 '22 08:08 BrandonWalker88