Add configuration and project parameters for ionic

[laurentyhuel]

Add support for monorepo project https://ionicframework.com/docs/cli/configuration#config-file with --project Add support for configuration https://ionicframework.com/docs/cli/commands/build#advanced-options with --configuration

[janpio]

I didn't know about these features, when were they added to Ionic CLI? Maybe that information should be added to the parameter description.

[laurentyhuel]

I found in doc for --project : https://ionicframework.com/docs/cli/configuration#multi-app-projects => Available in CLI 4.3.0+

I don't find for --configuration but it come with Angular 6: https://blog.angularindepth.com/becoming-an-angular-environmentalist-45a48f7c20d8 So I think with Ionic v4

[janpio]

Probably CLI 4.10.2 for --configuration: https://github.com/ionic-team/ionic-cli/blob/develop/packages/ionic/CHANGELOG.md#4102-2019-02-04

[laurentyhuel]

Ok I updated readme

[rvirani1]

This would be great to have. It's kinda clunky right now use angular staging environments.

[janpio]

@laurentyhuel I see you fixed some bugs, do you think this is good to merge now?

[laurentyhuel]

3 ionic commands are used by plugin:

ionic cordova platform add
ionic cordova prepare
ionic cordova compile

On official doc, --project parameter in not mentioned, --configuration parameter is mentioned only for prepare command. https://ionicframework.com/docs/cli/commands/cordova-platform https://ionicframework.com/docs/cli/commands/cordova-prepare https://ionicframework.com/docs/cli/commands/cordova-compile

I used ionic-cli version 4.12.0.

• For parameter "--project": On my projet (mono-repo), this parameter not works, I must execute command in the folder of sub-project.

• For parameter "--configuration": It works.

It's strange official doc not the same as release notes: https://github.com/ionic-team/ionic-cli/blob/develop/packages/ionic/CHANGELOG.md#4102-2019-02-04

But it seems to works as described in official doc and not release notes.

So there's possibilities:

1. I remove --project and keep --configuration
2. Keep both and --project will work in future version.

[mcailleaux]

We realy need this now for ci, it work fine localy on dev environment, is it possible to merge quickly?

[janpio]

No, just leaving for a short vacation. But you can use @laurentyhuel 's fork and branch from https://github.com/laurentyhuel/fastlane-plugin-ionic/tree/add-ionic-parameters2

[rvirani1]

Yup, we're having to use the fork for now. It would be great to get a new version with this merged in.

[laurentyhuel]

Hello @janpio , Is there something I need to do before you merge PR ?

[rubiktubik]

When this PR will be merged? It's already september 😅

[laurentyhuel]

Hello @janpio , It seems you forgot my PR ;-) or I miss something ?

[MarioC3]

Hi! Thank you all for your work. Quick question, will this be merge soon? I see this was made last year, but it wasn't merge to the project. I think a lot of people would find value in this PR. Thanks