fastify-url-data icon indicating copy to clipboard operation
fastify-url-data copied to clipboard

use `new URL` instead of `fast-uri`

Open gurgunday opened this issue 1 year ago • 1 comments

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

For the purposes of this plugin, using the built-in new URL seems to be a better choice as it is now faster than fast-uri for parsing URLs

Motivation

No response

Example

No response

gurgunday avatar Jan 24 '24 10:01 gurgunday

We should investigate if all the cases are optimized and not only the instantiation.

E.g. I optimized the performance of the MIMEType instanciation in nodejs, but getting variables of the MIMEType instance is still needing some additional work, and thus being slower than our implementation.

Uzlopak avatar Jan 24 '24 10:01 Uzlopak

@Uzlopak @gurgunday Given the discussion in #144 I think this can be closed? From looking at the benchmarks in that PR there's no real gains.

Fdawgs avatar Oct 05 '24 09:10 Fdawgs

I agree.

Uzlopak avatar Oct 05 '24 09:10 Uzlopak