fastify-helmet icon indicating copy to clipboard operation
fastify-helmet copied to clipboard

fix: fix deprecated subdependencies found warn(#248)

Open 0x0bit opened this issue 1 year ago • 10 comments

Checklist

0x0bit avatar Jun 26 '24 06:06 0x0bit

Those are only devDependencies, they won't affect the actual warnings on install

mcollina avatar Jun 26 '24 07:06 mcollina

Those are only devDependencies, they won't affect the actual warnings on install

Development dependencies are often installed and used during development, and by default, the npm install command installs all dependencies in the package.json file, including dependencies and devDependencies.

0x0bit avatar Jun 27 '24 06:06 0x0bit

@gurgunday ptal.

I think this should be rebased on the next branch.

mcollina avatar Jun 27 '24 08:06 mcollina

What is the current status of this?

0x0bit avatar Jul 15 '24 08:07 0x0bit

Taking a look

gurgunday avatar Jul 15 '24 08:07 gurgunday

Missing change in readme.md regarding code style button

Uzlopak avatar Jul 15 '24 08:07 Uzlopak

maybe take https://github.com/fastify/fastify/pull/5509 as reference

Uzlopak avatar Jul 15 '24 08:07 Uzlopak

by default, the npm install command installs all dependencies in the package.json file, including dependencies and devDependencies.

I don't think that is the truth as a dependencies in project.

mkdir repro
cd repro
npm install @fastify/helmet

You can see only dependencies is installed.

image

climba03003 avatar Jul 15 '24 09:07 climba03003

Interesting, normally it should also install devDeps

https://docs.npmjs.com/cli/v10/commands/npm-install#description

Maybe you have NODE_ENV set to production?

gurgunday avatar Jul 15 '24 09:07 gurgunday

Interesting, normally it should also install devDeps

npm install only install the devDependencies for the working project.

It never install devDependencies when you install package as a dependent.

climba03003 avatar Jul 15 '24 09:07 climba03003