fastify-helmet
fastify-helmet copied to clipboard
fix: fix deprecated subdependencies found warn(#248)
Checklist
- [x] run
npm run testandnpm run benchmark - [x] tests and/or benchmarks are included
- [x] documentation is changed or added
- [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct
Those are only devDependencies, they won't affect the actual warnings on install
Those are only devDependencies, they won't affect the actual warnings on install
Development dependencies are often installed and used during development, and by default, the npm install command installs all dependencies in the package.json file, including dependencies and devDependencies.
@gurgunday ptal.
I think this should be rebased on the next branch.
What is the current status of this?
Taking a look
Missing change in readme.md regarding code style button
maybe take https://github.com/fastify/fastify/pull/5509 as reference
by default, the npm install command installs all dependencies in the package.json file, including dependencies and devDependencies.
I don't think that is the truth as a dependencies in project.
mkdir repro
cd repro
npm install @fastify/helmet
You can see only dependencies is installed.
Interesting, normally it should also install devDeps
https://docs.npmjs.com/cli/v10/commands/npm-install#description
Maybe you have NODE_ENV set to production?
Interesting, normally it should also install devDeps
npm install only install the devDependencies for the working project.
It never install devDependencies when you install package as a dependent.