fastify-dx icon indicating copy to clipboard operation
fastify-dx copied to clipboard

Vue-router named route not working

Open toshoajibade opened this issue 1 year ago • 2 comments

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.11.0

Plugin version

0.1.0

Node.js version

16.3.1

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

MacOS Ventura 13.1

Description

Navigating using vue-router named route is not working both during programmatic navigation and when using RouterLink component. This is because the name of the route is not passed when creating the routes here, https://github.com/fastify/fastify-dx/blob/main/packages/fastify-vue/virtual/routes.js#L33.

To fix, I will suggest adding name: routeDef.name here.

I can open a PR for this.

Steps to Reproduce

  • Clone fastify-dx/vue starter template
  • In the index.vue file, change the RouterLink component to use a named route instead of a path.

Expected Behavior

The application should navigate to a new route

toshoajibade avatar Jan 19 '23 18:01 toshoajibade

That would be highly appreciated — the routing system needs some touches.

galvez avatar Jan 19 '23 19:01 galvez

I will do that. Thanks for the amazing work. This package has been a life saver for a project I am working on. 🙏

toshoajibade avatar Jan 21 '23 08:01 toshoajibade