fastify-diagnostics-channel icon indicating copy to clipboard operation
fastify-diagnostics-channel copied to clipboard

Won't work in Fastify v5

Open ben-hn opened this issue 1 year ago • 4 comments

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the regression has not already been reported

Last working version

4.28.1

Stopped working in version

5.0.0

Node.js version

20.17.0

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

rolling

💥 Regression Report

Just needs the compatible fastify version bumping to 5, and then releasing an update to NPM.

Steps to Reproduce

Install fastify 5, try and use this plugin

Expected Behavior

It shouldn't complain about not finding fastify v4

ben-hn avatar Sep 19 '24 10:09 ben-hn

This plugin does not make much sense in fastify v5. This feature is now built in: https://fastify.dev/docs/latest/Reference/Hooks/#diagnostics-channel-hooks.

mcollina avatar Sep 19 '24 10:09 mcollina

Ah perfect!

Might be worth chucking up a massive DEPRECATED banner on the README and linking to that page instead!

Thanks!

ben-hn avatar Sep 19 '24 12:09 ben-hn

@ben-hn would you like to send a PR?

mcollina avatar Sep 19 '24 12:09 mcollina

Released a new major with the deprecation warning: image

Feel free to add it to the readme

Eomm avatar Sep 21 '24 08:09 Eomm

As follow-up - I would archive this repo since it does not work with fastify v5 and it has been deprecated already

Any objection @fastify/plugins ?

Eomm avatar Mar 01 '25 06:03 Eomm

No objection here.

Fdawgs avatar Mar 01 '25 07:03 Fdawgs