fastify-cors icon indicating copy to clipboard operation
fastify-cors copied to clipboard

fix(types): make definitions `nodenext` compatible

Open SuperchupuDev opened this issue 3 years ago • 3 comments

Fixes #223

Checklist

SuperchupuDev avatar Sep 22 '22 18:09 SuperchupuDev

Do we have a typing test for this?

Uzlopak avatar Sep 22 '22 20:09 Uzlopak

CI is failing.

Uzlopak avatar Sep 23 '22 09:09 Uzlopak

I tried fixing the tests but the error messages are really complex for a person that doesn't know much about fastify's internals. Adding Partial<> to some types in the failing tests worked but I don't think that's an actual fix. Would anyone be willing to fix the tests, or at least point to the correct direction?

SuperchupuDev avatar Sep 23 '22 13:09 SuperchupuDev

@SuperchupuDev @climba03003

I fixed the typings.

Uzlopak avatar Oct 17 '22 12:10 Uzlopak