fastify-cookie icon indicating copy to clipboard operation
fastify-cookie copied to clipboard

How to use `hook: false`?

Open jpenna opened this issue 1 year ago • 1 comments

Hello,

I set hook: false when registering the plugin to avoid parsing cookies for all routes and only parse them manually for the routes I wanted to read cookies.

Turns out this setting also disables setting cookies:

https://github.com/fastify/fastify-cookie/blob/cd9f41509753423deedfb480760adf710a0b4ec9/plugin.js#L147:L150

Isn't it a better behavior if it only disables parsing incoming cookies, but allows for setting cookies for responses?

jpenna avatar Jun 27 '24 22:06 jpenna

They are both hooks, so I'd expect the hooks setting to affect both

gurgunday avatar Oct 09 '24 06:10 gurgunday