fastify-autoload icon indicating copy to clipboard operation
fastify-autoload copied to clipboard

Achieve 100% test coverage

Open jean-michelet opened this issue 1 year ago • 1 comments

Fixed #369

100%-test-coverage-fastify-autoload

I failed to cover some branches, so I have removed them. If you can find a way to fully evaluate these branches, please let me know. However, it's possible that they may be obsolete.

I've created an issues folder for issues related tests, which will need to follow this pattern: test/issues/<issue-number>/test.js. Since we're testing the autoloader, we need to create fixtures. This is why I chose to create a folder named after the issue instead of placing <issue-number>.js directly.

If you agree with this approach, I will update this PR to reflect these changes.

jean-michelet avatar Mar 16 '24 08:03 jean-michelet

Um...

I'm going to investigate.

jean-michelet avatar Mar 16 '24 10:03 jean-michelet

Waiting for #371 to be merged.

jean-michelet avatar Apr 19 '24 07:04 jean-michelet

You are targetting master, but #371 is targetting next

Uzlopak avatar Apr 19 '24 14:04 Uzlopak

Can we achieve this on master instead? I think it would be a moving target on next.

mcollina avatar Apr 20 '24 16:04 mcollina

Can we achieve this on master instead? I think it would be a moving target on next.

Should I try to fix the failing TS test here? Or it should be fixed in (or stay commented and fixed later) #371?

jean-michelet avatar Apr 20 '24 17:04 jean-michelet

The test that's failing here and the one in 371 are different I think

So for this PR, I'd suggest making the tests pass and merging to master, and then focusing on next's failing test at 371

gurgunday avatar Apr 20 '24 18:04 gurgunday

Ready For Review

jean-michelet avatar Apr 28 '24 15:04 jean-michelet