fast-uri icon indicating copy to clipboard operation
fast-uri copied to clipboard

bring back the support for Node.js v16

Open mcollina opened this issue 1 year ago • 6 comments

Given our goal for fast-uri to be the default of ajv, I think we should bring back support for Node.js v16. This would mean:

  • [x] switch to use tape instead of tap
  • [ ] use a custom action

mcollina avatar Jun 27 '24 08:06 mcollina

@gurgunday @jsumners wdyt?

mcollina avatar Jun 27 '24 08:06 mcollina

We already test for node 16? Did you mean node 14?

https://github.com/fastify/fast-uri/blob/986abce97b2303c69011da82805285a59e5967de/.github/workflows/ci.yml#L23

gurgunday avatar Jun 27 '24 09:06 gurgunday

Do we want a custom workflow to test it in the browser? I don’t understand why tape is needed

gurgunday avatar Jun 27 '24 09:06 gurgunday

latest tap does not support node v16 and v18.

mcollina avatar Jun 27 '24 10:06 mcollina

I think tape is acceptable in this case, because we could then also implement #21 easily, as it would be a copy paste solution from readable-stream repo.

Uzlopak avatar Jun 27 '24 10:06 Uzlopak

Won't AJV need to drop Node 16 in a few short (😭) months anyway?

jsumners avatar Jun 27 '24 12:06 jsumners

I just released AJV 8.17.1 with fast-uri. I hadn't seen this, but you're right, we'd be looking at dropping it soon. Hopefully this doesn't cause too many problems. I mean, 16 is about 6 months over the maintenance window.

Also it must work because our test suite runs 16 with fast-uri.

jasoniangreen avatar Jul 12 '24 20:07 jasoniangreen

We now use tape and the CI successfully tests fast-uri on node 16

For browser support, it should be working already, and the custom CI to run automated browser tests can be tracked at https://github.com/fastify/fast-uri/issues/21

gurgunday avatar Jul 14 '24 11:07 gurgunday