fast-proxy perf: replace querystring with fast-querystring

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Sep 09 '22 14:09 anonrig

@mcollina

Sep 09 '22 23:09 anonrig

following the other prs https://github.com/fastify/fastify-reply-from/pull/272

Could you please add an option to configure the querystring module to use? Like in Fastify.

Sep 11 '22 08:09 Eomm

@Eomm There's already an option to support this: https://github.com/fastify/fast-proxy#querystring

Sep 12 '22 12:09 anonrig

I released 1.0 and updated the pull request.

Sep 13 '22 13:09 anonrig

Any updates on this pull-request? @Eomm

Sep 20 '22 14:09 anonrig

Actually the remark by eomm is not solved. queryString option is an option to replace the querystring of a request it seems. But it is not an option to replace the querystring "engine" itself.

Sep 20 '22 14:09 Uzlopak

Yes, I totally missed that. I'll update the pull request. Thanks for the correction @Uzlopak

Sep 20 '22 14:09 anonrig

I added queryString parameter and updated both tests and docs. Can someone approve the workflow to run?

Sep 22 '22 12:09 anonrig

I think it's time to revive this pull request. Something is wrong with Github and requesting reviews. @RafaelGSS @Eomm Can you review it again please?

Oct 25 '22 18:10 anonrig

I'd appreciate it if someone can approve the workflow, once again. Thank you.

Oct 25 '22 19:10 anonrig

@mcollina I cannot release this package

we should bump a major since there are 3 major versions that has been merged by automerge

Oct 27 '22 17:10 Eomm