fast-proxy icon indicating copy to clipboard operation
fast-proxy copied to clipboard

merge/collaborate with http2-proxy?

Open ronag opened this issue 3 years ago • 5 comments

I believe there is some overlap here between this library and https://github.com/nxtedition/node-http2-proxy and just wanted to give a ping and see if there is any potential to combine efforts?

I'm looking to spend some extra time with it or something corresponding at some point in order to support undici.

ronag avatar Aug 10 '20 19:08 ronag

I noticed https://github.com/fastify/fastify-http-proxy doesn't use this library? That's a bit peculiar?

ronag avatar Aug 10 '20 19:08 ronag

This library was originally forked from fastify-reply-from. The idea of this repo being here is to reconcile them but this has been proven difficult.

BTW, I'm +1 in having a single one of those :).

mcollina avatar Aug 10 '20 22:08 mcollina

@ronag @mcollina Is this something you're both still interested in doing? I'd be very happy to help contribute, whether one of them is chosen as the "go forward" project, or starting a completely fresh repo for the common one.

jsmylnycky avatar Aug 19 '21 16:08 jsmylnycky

I'd be interested in seeing some benchmarks between http2-proxy and fast-proxy. In my somewhat rudimentary testing, it seems that http2-proxy is about as performant as http-proxy, with fast-proxy being anywhere from 2x to 4x faster.

On the other hand, the nice thing about http2-proxy is that it supports http2 and websockets. Is that possible with fast-proxy?

q0rban avatar Mar 28 '22 02:03 q0rban

@q0rban can confirm this. I used the same benchmark http2-proxy uses.

ChakshuGautam avatar Apr 25 '22 10:04 ChakshuGautam