create-fastify
create-fastify copied to clipboard
Update cmd.js
PR Description:
- Directory Handling: Uses
path.resolve()for consistent paths; defaults to the current directory (.) when no valid argument is provided. - Code Cleanup:
- Added semicolons to follow ECMAScript guidelines, preventing ASI issues.
- Removed redundant spread operator from
argsinitialization.
These changes improve script reliability and readability. Let me know if you need any adjustments.
I ran my own tests but felt it was unnecessary to include them in the pr.
Signed-off-by: @qbytx / Eva O'Brien [email protected]
Checklist
-
[x] run
npm run testandnpm run benchmark// tests passed for cmd.js -
[ ] tests and/or benchmarks are included // no features added
-
[ ] documentation is changed or added // documentation is unchanged
-
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct
Can you avoid any formatting changes? We don't use semicolons in this org. Please restore all the spread operators too.
CI is failing.
Can you avoid any formatting changes? We don't use semicolons in this org. Please restore all the spread operators too.
Certainly; just pushed a commit. 👍 and I will address any continuing CI failures soon
Will address these last CI issues this week
@qbytx are you still wanting to change this or can this be closed? We plan on archiving this repo.
Closing due to inactivity.