create-fastify icon indicating copy to clipboard operation
create-fastify copied to clipboard

Update cmd.js

Open qbytx opened this issue 1 year ago • 4 comments

PR Description:

  • Directory Handling: Uses path.resolve() for consistent paths; defaults to the current directory (.) when no valid argument is provided.
  • Code Cleanup:
    • Added semicolons to follow ECMAScript guidelines, preventing ASI issues.
    • Removed redundant spread operator from args initialization.

These changes improve script reliability and readability. Let me know if you need any adjustments.

I ran my own tests but felt it was unnecessary to include them in the pr.

Signed-off-by: @qbytx / Eva O'Brien [email protected]

Checklist

  • [x] run npm run test and npm run benchmark // tests passed for cmd.js

  • [ ] tests and/or benchmarks are included // no features added

  • [ ] documentation is changed or added // documentation is unchanged

  • [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

qbytx avatar Sep 27 '24 01:09 qbytx

Can you avoid any formatting changes? We don't use semicolons in this org. Please restore all the spread operators too.

mcollina avatar Sep 28 '24 06:09 mcollina

CI is failing.

mcollina avatar Sep 28 '24 06:09 mcollina

Can you avoid any formatting changes? We don't use semicolons in this org. Please restore all the spread operators too.

Certainly; just pushed a commit. 👍 and I will address any continuing CI failures soon

qbytx avatar Sep 28 '24 14:09 qbytx

Will address these last CI issues this week

qbytx avatar Oct 01 '24 17:10 qbytx

@qbytx are you still wanting to change this or can this be closed? We plan on archiving this repo.

Fdawgs avatar Jan 12 '25 10:01 Fdawgs

Closing due to inactivity.

Fdawgs avatar Jan 15 '25 14:01 Fdawgs