busboy icon indicating copy to clipboard operation
busboy copied to clipboard

add fieldNameSize for multipart

Open Uzlopak opened this issue 4 years ago • 1 comments

This PR is not ready for merge.

Discussion-points

  • Currently it checks for specific rfc-relevant fieldNames and does not apply fieldNameSize on those fieldnames. Should we remove that and just write in the documentation, that we recommend not to limit the fieldNameSize to some unreasonable value? If so it would remove this check for the specific fieldnames and in real world use cases you want to limit the fieldNameSize to something like 255 characters and not 3.
  • I assume that like in the added unit test, that "test" is a value and not a key so it should apply the fieldSize instead of the fieldNameSize, right?

Checklist

Uzlopak avatar Dec 02 '21 14:12 Uzlopak

Actually multipart seems to not respect fieldSize either.

Uzlopak avatar Dec 02 '21 16:12 Uzlopak