benchmarks icon indicating copy to clipboard operation
benchmarks copied to clipboard

Use throughput in result instead of requests

Open hekike opened this issue 6 years ago • 0 comments

Hi,

I'm not sure that I miss something or is it a bug:

autocannon-compare determinates the winner based on the throughput. See: https://github.com/mcollina/autocannon-compare/blob/9ba26c51775ba33986873087ccd69786fd635359/compare.js#L19

Shouldn't benchmarks use throughput for the diff calculation and in the result object instead of requests? See: https://github.com/fastify/benchmarks/blob/0f51ac40355b95f21f2fd415fefdf2415c808d08/lib/autocannon.js#L50

hekike avatar Nov 06 '17 09:11 hekike