ajv-compiler icon indicating copy to clipboard operation
ajv-compiler copied to clipboard

feat: enable Ajv2019 and Ajv2020

Open jmjf opened this issue 7 months ago • 2 comments

Closes #151 and probably makes #105 moot.

The for...of approach to tests seemed simple. If maintainers don't like it, I'm open to input on what you'd prefer.

  • [x] run npm run test ~and npm run benchmark~ (there is no benchmark script)
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Checklist

jmjf avatar Jun 07 '25 18:06 jmjf

Lint is failing in CI. When I ran lint locally on main, it failed with the same error. I'm not sure what the lint issue is.

jmjf avatar Jun 08 '25 00:06 jmjf

lint seems failing

Lint fails in main (see also this comment) with the same errors. At the time I created this PR, I saw several merged PRs that had the same lint failures.

If the team wants to recommend lint config changes the team considers acceptable, I'm willing to make them. (I use biome, not eslint, so am not familiar with eslint config.)

> @fastify/[email protected] lint
> eslint


/home/jmjf/dev/ajv-compiler/types/index.d.ts
  12:18  error  'buildCompilerFromPool' is defined but only used as a type    @typescript-eslint/no-unused-vars
  15:18  error  'buildSerializerFromPool' is defined but only used as a type  @typescript-eslint/no-unused-vars

✖ 2 problems (2 errors, 0 warnings)

jmjf avatar Aug 16 '25 14:08 jmjf