fastfetch icon indicating copy to clipboard operation
fastfetch copied to clipboard

[LOGO] MX Linux Logo?

Open dagleykd opened this issue 9 months ago • 6 comments

OS

MX Linux is currently the most popular distro on DistroWatch and is also an incredibly popular distro. Would love to see the logo added to fastfetch! Currently it only comes up as Debian. Yes, it is Debian-based, but it is not Debian :)

Ascii

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@%*+--:------=+*%@@@@@@@@@@@@
@@@@@@@@@#=. .-+#%@@@@@%#*+--=#@@@@@@@@@
@@@@@@@+. .=%@@@@@@@@@@@@@@@@*-:+@@@@@@@
@@@@@*.  *@@@@@@@@@@@@@@@@@@@@@%-.*@@@@@
@@@@-  -@@@@@@@@@@@@@@@@@@@@@@@#:  -@@@@
@@@:  -@@@@@@@=.*@@@@@@@@@@@@%-   = :@@@
@@=  .@@@@@@@@%- :%@@@@@@@@@+   -%@# =@@
@%   +@@@@@@@@@@#. =@@@@@@*.  .*@@@@. %@
@+   *@@@@@@*..*@@+  *@@%-   =@@@@@@- +@
@=   *@@@@%-    -%@@- :=   -%@@@@@@@: +@
@+   :@@@=        +@@=   .#@@@@@@@@%  *@
@%    +*.          .:     *@@#: +@@:  @@
@@+                   :%@- :-    ::  +@@
@@@-                  .=@@=         -@@@
@@+.                     .           +@@
%=..:.................::...........:..-%
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

dagleykd avatar May 02 '24 21:05 dagleykd

It should have been supported

https://github.com/fastfetch-cli/fastfetch/blob/dev/src/logo/ascii/mx.txt

You may test it with fastfetch -l mx

CarterLi avatar May 03 '24 00:05 CarterLi

It should have been supported

https://github.com/fastfetch-cli/fastfetch/blob/dev/src/logo/ascii/mx.txt

You may test it with fastfetch -l mx

It's not working automatically for me as it should be then? I'm running a standard install of MX 23.2 with the latest version of fastfetch but fastfetch comes up as Debian? Screenshot_2024-05-02_22-10-55

Is this a bug in my OS install somehow (I can't understand how it could be...?) or is this a bug in fastfetch maybe?

dagleykd avatar May 03 '24 01:05 dagleykd

What does cat /etc/os-release or cat /etc/lsb-release say?

CarterLi avatar May 03 '24 01:05 CarterLi

cat /etc/lsb-release

os-release:

PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

lsb-release:

PRETTY_NAME="MX 23.2 Libretto"
DISTRIB_ID=MX
DISTRIB_RELEASE=23.2
DISTRIB_CODENAME="Libretto"
DISTRIB_DESCRIPTION="MX 23.2 Libretto"

dagleykd avatar May 03 '24 01:05 dagleykd

Can you try this build?

https://github.com/fastfetch-cli/fastfetch/actions/runs/8933075710/artifacts/1469258998

CarterLi avatar May 03 '24 02:05 CarterLi

Can you try this build?

https://github.com/fastfetch-cli/fastfetch/actions/runs/8933075710/artifacts/1469258998

That did the trick with the logo, though the OS still identifies as "Debian GNU/Linux bookworm 12 x86_64"

I posted on the MX Linux forums a bit ago about it and one of the devs replied and said they are keeping the Debian-style os-release file as it is. Where MX is Debian-based, they need to leave it alone for the apt tool. https://forum.mxlinux.org/viewtopic.php?p=774701#p774701

Would there be a way to modify fastfetch to take some data from the lsb-release file instead specifically for fastfetch's 'OS' line at the top regarding MX (considering the MX devs are not going to modify the os-release file from it's Debian origins)...?

The rest of the fastfetch details seem fine, but maybe it could pull the 'OS' line from the 'Pretty Name' line in the lsb-release file instead?

dagleykd avatar May 03 '24 02:05 dagleykd

Tested in VM

image

CarterLi avatar May 03 '24 04:05 CarterLi

Tested in VM

image

Good morning!

My apologies for not answering last night - I had gone to bed :)

Up before work now. Just tested the new build and yes, it works perfectly now...kudos to you, and thanks very much for the quick replies / quick efforts and all the hard work that goes into fastfetch! :)

dagleykd avatar May 03 '24 10:05 dagleykd