fasten icon indicating copy to clipboard operation
fasten copied to clipboard

Optimization to building OPAL Class Hierarchies

Open mir-am opened this issue 2 years ago • 6 comments

Description

This is a small PR that makes the following changes:

  • creates a new method asURIHierarchyParallel() to create Fasten URIs in parallel. The speed up is 2 times, especially for large graphs.
  • Make createGraphWithExternalCHA faster by using parallel stream.

Overall, the speed up is up to 2-3x times.

Motivation and context

When creating (very large) partial call graphs, building FURI hierarchies can be very time-consuming if it's done in single-thread mode.

Testing

Unit tests pass for the OPAL plugin.

mir-am avatar Sep 15 '22 11:09 mir-am

@ashkboos, thanks a lot, Mehdi, for the contribution and help with the optimization of OPAL data structures.

mir-am avatar Sep 21 '22 12:09 mir-am

@ashkboos What is the verdict on this PR? Shall we merge it into develop?

mir-am avatar Oct 01 '22 10:10 mir-am

@ashkboos What is the verdict on this PR? Shall we merge it into develop?

To me it's fine. Unless Sebastian also wants to take a look.

ashkboos avatar Oct 01 '22 10:10 ashkboos

I would like to request a review from @proksch as he recently refactored OPALPartialCallGraphConstructor.

mir-am avatar Oct 01 '22 12:10 mir-am

What is the status of this PR? Do we still want to merge it?

MagielBruntink avatar Feb 21 '23 08:02 MagielBruntink

Hi Magiel,

We can still merge this PR, though it's not necessary. We made some improvements to class hierarchy construction to speed up experiments for research work.

On Tue, Feb 21, 2023, 11:58 MagielBruntink @.***> wrote:

What is the status of this PR? Do we still want to merge it?

— Reply to this email directly, view it on GitHub https://github.com/fasten-project/fasten/pull/490#issuecomment-1438091353, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEGEBVZHKWOVP76NG3ZUODWYR7UZANCNFSM6AAAAAAQNJRZHY . You are receiving this because you were assigned.Message ID: @.***>

mir-am avatar Feb 21 '23 11:02 mir-am