fasten
fasten copied to clipboard
Optimization to building OPAL Class Hierarchies
Description
This is a small PR that makes the following changes:
- creates a new method
asURIHierarchyParallel()
to create Fasten URIs in parallel. The speed up is 2 times, especially for large graphs. - Make
createGraphWithExternalCHA
faster by using parallel stream.
Overall, the speed up is up to 2-3x times.
Motivation and context
When creating (very large) partial call graphs, building FURI hierarchies can be very time-consuming if it's done in single-thread mode.
Testing
Unit tests pass for the OPAL plugin.
@ashkboos, thanks a lot, Mehdi, for the contribution and help with the optimization of OPAL data structures.
@ashkboos
What is the verdict on this PR? Shall we merge it into develop
?
@ashkboos What is the verdict on this PR? Shall we merge it into
develop
?
To me it's fine. Unless Sebastian also wants to take a look.
I would like to request a review from @proksch as he recently refactored OPALPartialCallGraphConstructor
.
What is the status of this PR? Do we still want to merge it?
Hi Magiel,
We can still merge this PR, though it's not necessary. We made some improvements to class hierarchy construction to speed up experiments for research work.
On Tue, Feb 21, 2023, 11:58 MagielBruntink @.***> wrote:
What is the status of this PR? Do we still want to merge it?
— Reply to this email directly, view it on GitHub https://github.com/fasten-project/fasten/pull/490#issuecomment-1438091353, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEGEBVZHKWOVP76NG3ZUODWYR7UZANCNFSM6AAAAAAQNJRZHY . You are receiving this because you were assigned.Message ID: @.***>