fastai2_audio icon indicating copy to clipboard operation
fastai2_audio copied to clipboard

Verify pipeline patch

Open PranY opened this issue 5 years ago • 3 comments

The verify_pipeline method covers the known edge-cases for the transforms pipeline. The design is to introduce an extensible framework to check future cases.

PranY avatar Apr 03 '20 02:04 PranY

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

The tests are breaking because of a problem while exporting the code from the notebooks. Please follow the instructions to fix it:

  • Install nbdev: pip install nbdev --upgrade
  • Install the git hooks (only need to do once): nbdev_install_git_hooks
  • Before each commit run the following commands:
pip install nbdev --upgrade
nbdev_clean_nbs
nbdev_build_lib
nbdev_build_docs
  • Optionally run nbdev_test_nbs to test the code

The instructions to contribute that are present on the repository at the moment are lacking, I will update them.

scart97 avatar Apr 11 '20 21:04 scart97

The instructions to contribute that are present on the repository at the moment are lacking, I will update them.

Surely we ca add those the into the pre-commit hook?

mogwai avatar Apr 14 '20 19:04 mogwai