fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

🌐 Fix markdown error in Korean translation for ```docs/ko/docs/deployement/*.md```

Open sodaMelon opened this issue 1 year ago • 6 comments

I corrected minor Markdown syntax errors and fixed bold formatting as per the original text.

also modified some typo.

(most problem appeared by markdown, because of korean postposition grammer. anyway maybe it will be better)

sodaMelon avatar Sep 06 '24 01:09 sodaMelon

šŸ“ Docs preview for commit 05fdfd2b42655c6ef0c5e4d1620e73aa5c3a1b99 at: https://7ebf1fb2.fastapitiangolo.pages.dev

Modified Pages

  • https://7ebf1fb2.fastapitiangolo.pages.dev/ko/deployment/
  • https://7ebf1fb2.fastapitiangolo.pages.dev/ko/deployment/cloud/
  • https://7ebf1fb2.fastapitiangolo.pages.dev/ko/deployment/docker/
  • https://7ebf1fb2.fastapitiangolo.pages.dev/ko/deployment/server-workers/
  • https://7ebf1fb2.fastapitiangolo.pages.dev/ko/deployment/versions/

github-actions[bot] avatar Sep 06 '24 01:09 github-actions[bot]

šŸ“ Docs preview for commit ccaf6705a035afc1ad9c979b2c1942b619b373db at: https://8c0fd9fb.fastapitiangolo.pages.dev

Modified Pages

  • https://8c0fd9fb.fastapitiangolo.pages.dev/ko/deployment/
  • https://8c0fd9fb.fastapitiangolo.pages.dev/ko/deployment/cloud/
  • https://8c0fd9fb.fastapitiangolo.pages.dev/ko/deployment/docker/
  • https://8c0fd9fb.fastapitiangolo.pages.dev/ko/deployment/server-workers/
  • https://8c0fd9fb.fastapitiangolo.pages.dev/ko/deployment/versions/

github-actions[bot] avatar Sep 06 '24 16:09 github-actions[bot]

hi could you check my PR for fast-api-docs? Most docs are broken, so very hard to read @hard-coders @jujumilk3

sodaMelon avatar Sep 07 '24 12:09 sodaMelon

Oh my, it seems the markdown parser has changed. The document is completely messed up. Thank you for fixing it. But in this way, a space is added after every bold text, which feels quite awkward in Korean documents. I’d like to check others' opinions as well.

jujumilk3 avatar Sep 07 '24 14:09 jujumilk3

Oh my, it seems the markdown parser has changed. The document is completely messed up. Thank you for fixing it. But in this way, a space is added after every bold text, which feels quite awkward in Korean documents. I’d like to check others' opinions as well.

Thanks

related to : https://github.com/fastapi/fastapi/pull/12148 https://github.com/fastapi/fastapi/pull/12142 https://github.com/fastapi/fastapi/pull/12141 https://github.com/fastapi/fastapi/pull/12136

sodaMelon avatar Sep 07 '24 15:09 sodaMelon

Oh my, it seems the markdown parser has changed. The document is completely messed up. Thank you for fixing it. But in this way, a space is added after every bold text, which feels quite awkward in Korean documents. I’d like to check others' opinions as well.

It is caused by pymdown-extensions. See also: https://github.com/fastapi/fastapi/pull/12161

andychucs avatar Sep 08 '24 10:09 andychucs

Hi @sodaMelon

This was handled in PR #12509, it should be fixed now. so I'm going to close this one but thanks for the interest and effort! :raised_hands:

alejsdev avatar Oct 22 '24 20:10 alejsdev