fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

📝 Update TrustedHostMiddleware Documentation

Open soulee-dev opened this issue 1 year ago • 8 comments

Summary

This PR updates the documentation for TrustedHostMiddleware to reflect the current code more accurately.

Changes

  1. TrustedHostMiddleware:
  • Added documentation for the www_redirect parameter. When set to True, this option redirects requests to non-www versions of allowed hosts to their www counterparts. This parameter defaults to True.

Related PR

https://github.com/encode/starlette/pull/2572 (Merged)

soulee-dev avatar Apr 15 '24 11:04 soulee-dev

📝 Docs preview for commit c94e31fdb0cf2c04635263ba46a22989df3aafbc at: https://4b7052da.fastapitiangolo.pages.dev

tiangolo avatar Apr 15 '24 11:04 tiangolo

📝 Docs preview for commit ba3d6938e156ef55064b9fd6d24e75aeb127b3d0 at: https://788da276.fastapitiangolo.pages.dev

tiangolo avatar Apr 15 '24 11:04 tiangolo

📝 Docs preview for commit 62bc4115a3f00f2b8d69b42cd6bc24acf11bdc48 at: https://3aae0164.fastapitiangolo.pages.dev

tiangolo avatar Apr 19 '24 15:04 tiangolo

@alejsdev Is there any steps that I have to do?

soulee-dev avatar Apr 19 '24 16:04 soulee-dev

📝 Docs preview for commit c8d0158ed75d52f3d9a71751822a2d440bfb6343 at: https://8e94391e.fastapitiangolo.pages.dev

tiangolo avatar Apr 20 '24 03:04 tiangolo

📝 Docs preview for commit d90a85a5a176f55c1e809f02ab2168a5175ee995 at: https://9846840b.fastapitiangolo.pages.dev

tiangolo avatar Apr 23 '24 14:04 tiangolo

@alejsdev The updates have already been applied to the Starlette documentation. Here is the link for your reference: Starlette Middleware Documentation. Could you please merge my pull request for the FastAPI documentation as well?

soulee-dev avatar Jul 23 '24 15:07 soulee-dev

📝 Docs preview for commit 4894a037e59736ac16c0ac638394df445746be35 at: https://5e9c50ee.fastapitiangolo.pages.dev

tiangolo avatar Jul 23 '24 15:07 tiangolo

📝 Docs preview for commit 7f7c47a3f1deccec704a242b87ccc1ac4fc84b19 at: https://08dcc22a.fastapitiangolo.pages.dev

Modified Pages

  • https://08dcc22a.fastapitiangolo.pages.dev/advanced/middleware/

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]

@svlandeg Thank you for merge recent commits!

If you don't mind, Could you review my PR?

soulee-dev avatar Aug 28 '24 12:08 soulee-dev

Hi @soulee-dev,

Thanks for your PR! We're currently going through the backlogs of PRs. There's no need to ping individual maintainers - we'll definitely get to review your PR, it's in our queue. Thanks for your patience! 🙏

svlandeg avatar Aug 28 '24 13:08 svlandeg