nbdev icon indicating copy to clipboard operation
nbdev copied to clipboard

`nbdev_conda` not honoring the license choice

Open xl0 opened this issue 3 years ago • 1 comments

The license is unconditionally set to "Apache" at the moment; see _get_conda_meta in https://github.com/fastai/nbdev/blob/master/nbs/api/release.ipynb

Should it be changed to take in cfg.get('license'), and the license_family field dropped? conda-build will deduct the license family from the name if it's not specified.

On a related note, conda-forge requires that we set the license_file https://github.com/conda-forge/staged-recipes/blob/main/.github/pull_request_template.md

https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#license-file

If there is no reason against it, Is it safe to hard-code it to be just LICENSE? It's picked up from PyPI automatically.

xl0 avatar Nov 26 '22 13:11 xl0

Would be nice if the team could comment, as I'm about to submit a PR for _get_conda_meta with cleaned up requirements list that will make more packages compile without issues.

michaelaye avatar Mar 21 '23 15:03 michaelaye