nbdev-template icon indicating copy to clipboard operation
nbdev-template copied to clipboard

Update `.gitignore` and `workflows` "pr" (I tired but I don't have perms).

Open dsm-72 opened this issue 2 years ago • 3 comments

.gitignore

# ......................................
# Distribution / packaging
.Python
env/
build/
conda/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
*.egg-info/
.installed.cfg
*.egg
# ...................................

deploy.yaml

# .github/workflows/deploy.yaml
name: Deploy to GitHub Pages

permissions:
  contents: write
  pages: write

on:
  push:
    branches: [ "main", "master" ]
  workflow_dispatch:
jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: fastai/workflows/quarto-ghp@master
        with:
          version: '3.10'

test.yaml

# .github/workflows/test.yaml
name: CI
on:  [workflow_dispatch, pull_request, push]

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: fastai/workflows/nbdev-ci@master
        with:
          version: '3.10'

dsm-72 avatar Jun 04 '23 21:06 dsm-72

@seeM any ideas?

dsm-72 avatar Jun 07 '23 14:06 dsm-72

I'd recommend one of the solutions mentioned in my other comment.

For the .gitignore specifically, you could make a PR to this repo (fork the repo, make the change on your fork, then create a pull request to this upstream repo).

I'm curious why you want to restrict to version 3.10?

seeM avatar Jun 07 '23 15:06 seeM

@seeM I don't want to restrict to 3.10. The default is 3.9 and 3.10 has some major break changes (like numpy)

dsm-72 avatar Jun 07 '23 15:06 dsm-72