fastprogress icon indicating copy to clipboard operation
fastprogress copied to clipboard

Fixes issue #69 Visual Studio Code does not render progress bars corr…

Open hsm opened this issue 5 years ago • 5 comments
trafficstars

…ectly

hsm avatar Sep 04 '20 17:09 hsm

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

sorry @hsm I only just saw this. it's a good idea, although it means that fastprogress won't work unless ipywidgets is installed. how about only using ipywidgets in the case where the user is on vscode?

BTW, you need to nbdev_install_git_hooks to ensure you have a clean NB in your PR.

jph00 avatar May 20 '22 22:05 jph00

Hi, I hit this bug in VSCode and used the monkeypatch @hsm wrote in this post here to fix it:

from IPython.display import clear_output, DisplayHandle
def update_patch(self, obj):
    clear_output(wait=True)
    self.display(obj)
DisplayHandle.update = update_patch

Any chance some sort of fix can be merged into the main branch? It's been impacting quite a few users I think for over 2 years now.

guillochon avatar Mar 15 '23 02:03 guillochon

@guillochon note that progress bars were working in VSCode and only stopped a few days ago. This is an old PR that I guess was fixed in a different way. Here is the new issue https://github.com/fastai/fastprogress/issues/104

Either way your workaround is useful for the current issue, thanks. You may want to post your workaround on the issue, it is closer to the intended output than the suggestions.

codewithcheese avatar Mar 21 '23 03:03 codewithcheese

#104 now has some specific detail in this comment thanks to @bosmart, https://github.com/fastai/fastprogress/issues/104#issuecomment-1482350888

codermrrob avatar Mar 24 '23 08:03 codermrrob