fastcore icon indicating copy to clipboard operation
fastcore copied to clipboard

shouldn't `rnum_methods` and `inum_methods` be set in `fastuple`?

Open fredguth opened this issue 2 years ago • 0 comments

Noticed that rnum_methods and inum_methods are exported but never set into fastuple: https://github.com/fastai/fastcore/blob/f7fea257626106e2016d4a55d280f8b876f6dcb4/fastcore/basics.py#L795

Shouldn't it be:

for n in num_methods + rnum_methods +inum_methods:
    if not hasattr(fastuple, n) and hasattr(operator,n): setattr(fastuple,n,_get_op(n))

?

fredguth avatar Feb 22 '23 12:02 fredguth