fastbook icon indicating copy to clipboard operation
fastbook copied to clipboard

Regenerate `clean/` folder + Fix notebook validation errors caused by extra fields

Open gunchu opened this issue 2 years ago • 1 comments

Regenerating before making change to one of the notebooks.

Surprisingly (or because of my lack of knowledge of how to use nbdev/execnb libs) current read_nb() function adds these unexpected keys to notebook JSON:

  1. idx_ to all the cells
  2. path_ to the root

These result in errors of the following type when notebook is opened:

Notebook validation failed: Additional properties are not allowed ('idx_' was unexpected):

To address this issue, the proc_nb() function has been modified to forcefully delete these keys. Future improvements could involve implementing a cleaner solution, such as refining the clean_nb() function in the nbdev library.

gunchu avatar Mar 30 '23 04:03 gunchu

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB