Matthias Fasching
Matthias Fasching
### What is being done in this PR? This PR restores dependabot for this repository. ### What are the main choices made to get to this solution? A lost of...
`g_spacemesh_api_abort_flag` (defined here https://github.com/spacemeshos/gpu-post/blob/develop/src/api_internal.cpp#L15) is used as a termination condition to stop calculation of hashes early (e.g. here https://github.com/spacemeshos/gpu-post/blob/develop/src/cuda/driver-cuda.cpp#L220). This global variable isn't protected from concurrent access, so stopping a...
The release job defined in `build.yml` doesn't work as expected. It only runs when the push that triggered the execution of the Github action happened on `master` and included a...
This project is missing a linter that checks the code for issues. A commonly used linter is [clang-tidy](https://clang.llvm.org/extra/clang-tidy/). It should check the code during every build and prevent tests from...
At the moment tests are written and executed "by hand". Instead we should use a testing framework like https://github.com/google/googletest or https://github.com/boostorg/test and remove all the boilerplate code that invokes our...
At the moment the code is inconsistently formatted. I suggest to use a code formatting tool like `clang-format` to get consistently formatted code. Maybe we can also add a test...
Both `spacemeshos/poet` (see [harness.go](https://github.com/spacemeshos/poet/blob/e8e3525/integration/harness.go)) and `spacemeshos/go-spacemesh` (see [poet_test_harness.go](https://github.com/spacemeshos/go-spacemesh/blob/5eeb1a2/activation/poet_test_harness.go)) contain a harness that can be used for (integration) testing against poet. It would be beneficial if we would consolidate these two...
With the introduction of dependabot a small issue popped up; PRs created with dependabot failed their CI builds (e.g. this one: https://github.com/spacemeshos/poet/pull/117) The reason for that is that dependabot doesn't...
This improves the extensions for ED25519 to be more efficient. They are now on par with the ed25519 versions of the standard library: without upgrade: ``` BenchmarkPublicKeyExtraction-6 6681 174333 ns/op...
Since `go install` and `go get` support the installation of specific dependencies / tools via version identifier it should be used instead of a `tools.go` file to add those dependencies....