HDWallet icon indicating copy to clipboard operation
HDWallet copied to clipboard

Add initial support for Cosmos.

Open tritao opened this issue 4 years ago • 4 comments
trafficstars

As the title says, adds support for Cosmos-based networks.

Tested against the terra.js SDK.

tritao avatar Oct 16 '21 11:10 tritao

Awesome, I will check as soon as possible.

farukterzioglu avatar Oct 17 '21 07:10 farukterzioglu

Does Cosmos have any implementation other than Secp256k1? If not we can name it as just CosmosHDWallet not CosmosHDWalletSecp256k1. All of the wallets follow this naming, except Tezos which has both Secp256k1 and Ed25519 (not in this project though) implementation. Thats why it is called as TezosHDWalletSecp256k1

If cosmos doesn't have Ed25519 implemenration in use, you can name it to CosmosHDWallet

farukterzioglu avatar Oct 17 '21 07:10 farukterzioglu

Does Cosmos have any implementation other than Secp256k1? If not we can name it as just CosmosHDWallet not CosmosHDWalletSecp256k1. All of the wallets follow this naming, except Tezos which has both Secp256k1 and Ed25519 (not in this project though) implementation. Thats why it is called as TezosHDWalletSecp256k1

If cosmos doesn't have Ed25519 implemenration in use, you can name it to CosmosHDWallet

Sounds good, I will update the PR with the rename.

tritao avatar Oct 18 '21 14:10 tritao

@tritao Could you get the latest changes from master and do the mentioned changes above, so I can merge this.

farukterzioglu avatar Mar 04 '22 22:03 farukterzioglu