airbyte-connectors icon indicating copy to clipboard operation
airbyte-connectors copied to clipboard

Fix in 'buildPipeline' function

Open claudio-mas opened this issue 11 months ago • 8 comments

Description

This pull request fixes a bug in the buildPipeline function. The change made was:

  • selector: {type: data.target?.selector.type},
  • selector: {type: data.target?.selector?.type},

Type of change

  • [x] Bug fix
  • [ ] New feature
  • [ ] Breaking change

Explanation:

The previous version of the buildPipeline function did not work correctly if the selector field was null or undefined. This happened because the code tried to access the type field of a null object, which resulted in an error.

The change fixes this issue by checking if the selector field exists before accessing the type field. If the selector field is null or undefined, the function will return an empty object.

Benefits:

This fix improves the reliability and robustness of the buildPipeline function. It prevents errors from being thrown if the selector field is null or undefined.

Testing:

I tested this change locally and it works as expected. I created a test case where the selector field was null and the function returned the empty object as expected.

I look forward to your review and approval.

claudio-mas avatar Mar 04 '24 17:03 claudio-mas

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Mar 04 '24 17:03 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

claudio-mas avatar Mar 04 '24 17:03 claudio-mas

@claudio-mas Thank you for your contribution! We do required signed commits though. Could you please sign your commit? I'll approve then 🙏

ypc-faros avatar Mar 04 '24 18:03 ypc-faros

@claudio-mas Thank you for your contribution! We do required signed commits though. Could you please sign your commit? I'll approve then 🙏

@ypc-faros I'm not sure if I did it correctly, is there something else missing on my part? Thank you 👍

claudio-mas avatar Mar 06 '24 13:03 claudio-mas

@claudio-mas Thanks for fixing this! Could you rebase/squash your commits and force-push your branch so that all the commit(s) are signed? The first commit in your branch is still unsigned and therefore blocking us from merging.

cjwooo avatar Mar 15 '24 16:03 cjwooo

@claudio-mas Thanks for fixing this! Could you rebase/squash your commits and force-push your branch so that all the commit(s) are signed? The first commit in your branch is still unsigned and therefore blocking us from merging.

@cjwooo I don't think I'll be able to sign the first commit, could this be resolved by redoing the pull request?

claudio-mas avatar Mar 22 '24 13:03 claudio-mas

@claudio-mas Apologies for late response, creating a new branch, commit, and PR should resolve it.

cjwooo avatar Apr 02 '24 21:04 cjwooo

Duplicated change with https://github.com/faros-ai/airbyte-connectors/pull/1451

cjwooo avatar May 13 '24 23:05 cjwooo