pannellum-react icon indicating copy to clipboard operation
pannellum-react copied to clipboard

Typescript support

Open teddybee opened this issue 3 years ago • 6 comments

It would be great to have type definition package for this lib.

teddybee avatar Jan 11 '22 03:01 teddybee

I try my best but I can't promise... I'll be active after couple of years on this repo and try to upgrade some packages and also move to functional react and hooks

farminf avatar Feb 22 '22 14:02 farminf

for the moment I used the augmentation as this

declare module "pannellum-react" {
  function Pannellum(props: any): JSX.Element;
}


kayvaninvemo avatar Mar 09 '22 17:03 kayvaninvemo

I also created a repo to support TypeScript, I can create PR if you like it

kayvaninvemo avatar Apr 09 '22 09:04 kayvaninvemo

yes sir, please :)

farminf avatar Apr 18 '22 15:04 farminf

Here I created the PR

kayvaninvemo avatar May 02 '22 12:05 kayvaninvemo

@farminf How would you feel about releasing a new npm version with this change?

arcticfly avatar Sep 29 '22 21:09 arcticfly