farmerbb
Improve Editor Usability
Issues Fixed
- When using autocorrect and pressing enter so the word is corrected instead of replacing the misspelled word with the correction we find the correction is just placed on the next line
- I assume this happens because
onValueChangedoes not execute after all changes are finished whileoutputTransformationhappens after all changes to the text state
- I assume this happens because
- When editing a note the keyboard opens to cover the cursor. Instead the text will now scroll to show the cursor
- I don't know why this is fixed using a different constructor for
BasicTextFieldbut it seems this has been an issue for a while with this component (https://issuetracker.google.com/issues/237190748)
- I don't know why this is fixed using a different constructor for
New Behavior
When markup/html is disabled double tapping to edit will put the cursor where you tapped instead of at the end of the note. I don't know if this is useful for most users or if there should be a setting to toggle this behavior.
Tickets Addressed
#157 #158
Fantastic, it'd be great to see if this fixes the problems I have too. Great work!
Hey, @farmerbb could we get this merged, see if it fixes some of the bugs there are? Thanks
shut the fuck up
Sesh, 5-avg, 2025, 03:52 robin-paulson @.***>:
robin-paulson left a comment (farmerbb/Notepad#162) https://github.com/farmerbb/Notepad/pull/162#issuecomment-3152670750
Hey, @farmerbb https://github.com/farmerbb could we get this merged, see if it fixes some of the bugs there are? Thanks
— Reply to this email directly, view it on GitHub https://github.com/farmerbb/Notepad/pull/162#issuecomment-3152670750, or unsubscribe https://github.com/notifications/unsubscribe-auth/APSQOOVB2LPYEPSBOAWVCH33L7PZBAVCNFSM6AAAAABT4FLUDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJSGY3TANZVGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
shut the fuck up Sesh, 5-avg, 2025, 03:52 robin-paulson @.***>:
oh dear, that's very sad. are you ok?
dont disturb me. yall annoying
Pay, 7-avg, 2025, 06:46 robin-paulson @.***>:
robin-paulson left a comment (farmerbb/Notepad#162) https://github.com/farmerbb/Notepad/pull/162#issuecomment-3162149085
shut the fuck up Sesh, 5-avg, 2025, 03:52 robin-paulson @.***>:
oh dear, that's very sad. are you ok?
— Reply to this email directly, view it on GitHub https://github.com/farmerbb/Notepad/pull/162#issuecomment-3162149085, or unsubscribe https://github.com/notifications/unsubscribe-auth/APSQOOXW2ACHS44K2TH33A33MKVV3AVCNFSM6AAAAABT4FLUDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRSGE2DSMBYGU . You are receiving this because you commented.Message ID: @.***>
@superjkl Thanks, I really appreciate you getting these fixes implemented!
Could you tag a new release, so fdroid will pull the new code? Thanks
@farmerbb Please get this new version with fixes published. Thank you!
Is it possible to make a PR which drafts a release, so all the maintainer needs to do is approve it? Anything to make it easier for someone who may be snowed under with commitments
@superjkl Can you help please with the above PR for the release, I can't do it (don't know how). Thank you!
Checking the fdroid metadata (https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.farmerbb.notepad.yml) it looks like fdroid will build a new release if a tag is added to the repo. Unfortunately a tag cannot be added through a pull request, but it is simple for the maintainer to do so themselves.
Checking the fdroid metadata (https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.farmerbb.notepad.yml) it looks like fdroid will build a new release if a tag is added to the repo. Unfortunately a tag cannot be added through a pull request, but it is simple for the maintainer to do so themselves.
Ah, OK thanks for looking it up
Checking the fdroid metadata (https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.farmerbb.notepad.yml) it looks like fdroid will build a new release if a tag is added to the repo. Unfortunately a tag cannot be added through a pull request, but it is simple for the maintainer to do so themselves.
@farmerbb Are you the only person on the project who can add the "tag" described above? Who else can help? Thank you.
@pi99y and @superjkl Given farmerbb appears to not have the time or inclination to make a new release, I wonder what other routes we can take. We could fork the software, then submit it for inclusion in F-Droid. That of course has costs, in the form of time and effort to submit and then be the maintainer. What do you both think, is it worth talking with other contributors about this?
Forking would be unfortunate because migrating notes to a new app is still a painful process for users, but not impossible.
Although adding a tag is as simple as running git tag <version>; git push --tags the maintainer was probably hoping to test the changes more before making a release.
It would be greatly appreciated if the maintainer could make a release though.
He may just not see the comments being made here. Don't harass him but you may be able to give him a polite and friendly poke on reddit with a DM
He may just not see the comments being made here.
I recall maintainers on github by default are notified of all comments on their repos. Issues, PRs, the lot.
Don't harass him
Absolutely, please don't!
We could also offer to take over maintenance of the repo.